Documentation #73
Merged
Documentation #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfertel
requested changes
Jun 7, 2024
src/bit_manipulation/basic.rs
Outdated
Comment on lines
625
to
628
| // `((x | (x - 1)) + 1) & x == 0` | ||
| // | ||
| // Also `((x & -x) + x) & x == 0` | ||
|
|
There was a problem hiding this comment.
Hmmm, it would be weird to leave these comments here, right?
Regarding is_power_of_two_difference, it wasn't really clear here, but this function doesn't check if a number is a power of two, but instead if it is the difference of two powers of two.
Namely 2^k - 2^j.
If it's not clear lmk and I'll expand a bit more on this.
| pub fn multiply_signed(a: i8, b: i8) -> i8 { | ||
| println!("{} {}", a, b); |
…correctly match the function instead of saying it is checking for a power of two in a different way.
|
That should fix the issues! =D |
alexfertel
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation in the bit_manipulation/basic.rs section.
I've added both module documentation as well as documentation for all functions in the module:
get_bit, set_bit, clear_bit, update_bit, is_even, is_positive, multiply_by_two, divide_by_two, twos_complement, multiply_signed, multiply_unsigned, count_ones, bit_equivalence, bit_distance, is_power_of_two, is_power_of_two_difference, rightmost_one, and rightmost_zero.
I'm a bit concerned about
is_power_of_two_difference, I think it might not be correctly detecting values. I have not changed the actual code though.