labs Aleksei Pakhomov #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Сделайте свой репозиторий приватным, пожалуйста. |
alexeyr
reviewed
Mar 29, 2024
| intersect [] _ = [] | ||
| intersect (x:xs) (y:ys) | ||
| | x == y = [x] ++ intersect xs ys | ||
| | otherwise = intersect xs ys |
Owner
There was a problem hiding this comment.
Я не вижу, как у вас проходит тест
intersect [1, 2, 3] [3, 4, 5] `shouldBe` [3]
У меня там получается пустой список с такой реализацией. Первый пример в задании тоже не должен работать.
Owner
|
Кроме ошибки в intersect, всё остальное отлично. Ставлю 18, её можно исправить и получить 20. |
Owner
|
Можете лабораторные 2 и 3 вынести в отдельные PR? |
alexeyr
reviewed
Jun 25, 2024
Comment on lines
+12
to
+32
| coprime :: Integer -> Integer -> Bool | ||
| coprime a b | ||
| | c == 0 || d == 0 = False | ||
| | c == 1 || d == 1 = True | ||
| | c > d = coprime (c - d) d | ||
| | otherwise = coprime (d - c) c | ||
| where c = abs a | ||
| d = abs b | ||
|
|
||
| max3, median3 :: Integer -> Integer -> Integer -> Integer | ||
| max3 x y z = if max x y >= z then max x y else z | ||
| median3 x y z = if max x y >= z then (if x >= y then max y z else max x z) else max x y | ||
|
|
||
| newtype Poly a = Poly [a] | ||
| xPows x = map (\n -> x**n) [0..] | ||
| getCoefs (Poly p) = p | ||
| discardZeroes [] = [] | ||
| discardZeroes p = if (last p /= 0) then p | ||
| else discardZeroes $ init p | ||
| makePoly p x = sum $ zipWith (*) (getCoefs p) (xPows x) | ||
| applyPoly p x = makePoly p x |
Owner
There was a problem hiding this comment.
Сами функции добавили, а тесты для них нет.
Owner
Уже не надо, я посмотрел изменения с последней проверки. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.