Lab3 Rudnevskiy #10
Open
Lab3 Rudnevskiy #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeyr
reviewed
Jun 25, 2024
| (==) = undefined | ||
| (==) (P a) (P b) = checkNull a == checkNull b where | ||
| checkNull [] = [] | ||
| checkNull lst = if (last lst == 0) then checkNull (init lst) else lst |
Owner
There was a problem hiding this comment.
Это очень неэффективная реализация из-за медленных last и init, но ладно.
Comment on lines
+27
to
+34
| it "xor" $ do | ||
| xor True True `shouldBe` False | ||
| xor True False `shouldBe` True | ||
| xor False True `shouldBe` True | ||
| xor False False `shouldBe` False | ||
| it "geomProgression" $ do | ||
| geomProgression 5.0 0.5 2 `shouldBe` 1.25 | ||
| geomProgression 5.0 2.0 3 `shouldBe` 40.0 |
Owner
There was a problem hiding this comment.
Функции добавили и QuickCheck раскомментировали, но тесты-то без QuickCheck! Из-за своей задержки я поставлю полный балл с возможностью его увеличить, добавив тесты в QuickCheck.
Comment on lines
92
to
+104
| {- -O0: Total time: ??? Total Memory in use: ??? -} | ||
| {- -O2: Total time: ??? Total Memory in use: ??? -} | ||
| minMax = undefined | ||
| minMax [] = Nothing | ||
| minMax (x:xs) = Just (foldl update (x, x) xs) where | ||
| update (minVal, maxVal) current = (min minVal current, max maxVal current) | ||
|
|
||
| -- Дополнительное задание: реализуйте ту же самую функцию (под названием minMaxBang) с | ||
| -- использованием явной строгости (seq и/или !) | ||
|
|
||
| {- -O0: Total time: ??? Total Memory in use: ??? -} | ||
| {- -O2: Total time: ??? Total Memory in use: ??? -} | ||
| minMaxBang = undefined | ||
| minMaxBang [] = Nothing | ||
| minMaxBang (x:xs) = Just (foldl (\(mn, mx) y -> (min mn y, max mx y)) (x, x) xs) |
Owner
There was a problem hiding this comment.
Это та же реализация, что выше, только с другими названиями переменных, без seq и без !.
Owner
|
Тут замечания есть, но я поставлю полные баллы за 2 и 3 лабораторные, и при исправлении можно ещё увеличить. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.