pgxstore: Fix race condition in cleanup #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pete-woods
commented
Apr 9, 2024
pete-woods
commented
- Run this test with the race detector on
- Run this test with the race detector on
pete-woods
changed the title
|
@pete-woods Thank you for this fix. I'll merge it now, and I've opened issue #231 to check other stores and fix the same race in them. |
|
@alexedwards if you're in here, please have a look at my PR that adds a GitHub actions workflow. I wanted to help you be able to validate external contributions like this more easily. It's got setup for several of the session stores. It's #205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.