Skip to content

Prepare code for WRS calls. - #1

Open
acflorea wants to merge 16 commits into
alexandrupaler:masterfrom
acflorea:wrs
Open

Prepare code for WRS calls.#1
acflorea wants to merge 16 commits into
alexandrupaler:masterfrom
acflorea:wrs

Conversation

@acflorea

Copy link
Copy Markdown

Added main method, prepare code for WRS calls.

@alexandrupaler

Copy link
Copy Markdown
Owner

Have a look at training.py and you can add the main method call to that file.

@acflorea

Copy link
Copy Markdown
Author

Done. TY!
There are two remaining questions in the comments.

Comment thread training.py
Comment thread training.py Outdated
@acflorea

Copy link
Copy Markdown
Author

Adjusted according to your answers. I've left the two loops in place - since we have both the optimal_depth and depth_result I feel it would make more sense to minimise their square difference - what do you think ?

Still wondering if sum or average over all results in the loop ...

@alexandrupaler

Copy link
Copy Markdown
Owner

Chose whatever you think optimises best. Square difference should be fine too. However, our values will be only on the rhs of the optimum. Because our optimum is a minimum value, all differences will be positive.

Comment thread run.sh Outdated
@@ -0,0 +1,4 @@
#!/bin/bash
cd /Users/acflorea/phd/k7m/

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid absolute paths related to your computer

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a folder called wrs where the scripts and code related to wrs is stored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants