Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update signature algorithm validation from sha-1 to sha-256 #200

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

doiron
Copy link
Contributor

@doiron doiron commented Mar 31, 2022

Description

Upgrading the ASK SDK Python WebService skill request signature verification handler to use the SHA256withRSA signature algorithm using the Signature-256 request header in order to validate the request is a valid Alexa HTTP requests.

Motivation and Context

This change is part of a multi-phase effort to move off of SHA-1 algorithm for all tls usage.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@doiron doiron merged commit 0da456c into master Apr 1, 2022
@doiron doiron deleted the doiron-sha256-2 branch April 1, 2022 02:14
@thorrak
Copy link

thorrak commented May 23, 2023

I think this has created an issue with Django support #202

@thorrak
Copy link

thorrak commented May 23, 2023

The bugfix for the bug this introduced in Django support is in PR #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants