Skip to content

Conversation

@aliel
Copy link
Member

@aliel aliel commented Dec 31, 2025

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • All new code is covered by relevant tests.

Documentation

TODO

Changes

the upload command support file or directory for the uploading task and check the user balance before sending files to the servers

How to test

aleph file upload __directory__

@aliel aliel requested a review from 1yam December 31, 2025 19:36
@github-actions
Copy link

Failed to retrieve llama text: POST 502: Bad Gateway

@aliel aliel force-pushed the aliel-add-directory-upload-feature branch from 1233b05 to 00bbb93 Compare January 6, 2026 18:16
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 35.89744% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.73%. Comparing base (93c9c6d) to head (00bbb93).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/files.py 35.89% 48 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
- Coverage   61.26%   60.73%   -0.54%     
==========================================
  Files          20       20              
  Lines        3971     4024      +53     
  Branches      585      595      +10     
==========================================
+ Hits         2433     2444      +11     
- Misses       1262     1303      +41     
- Partials      276      277       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aliel
Copy link
Member Author

aliel commented Jan 6, 2026

waiting aleph-im/aleph-sdk-python#271

Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliel aliel merged commit a9dae01 into master Jan 8, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants