Prevent hdf5 calling atexit() #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could create double free situations, where an orphaned thread would try to access a handle after it's been freed by the main thread.
mulimoen
force-pushed
the
bugfix/dont_atexit
branch
from
fd5aed7 to
45da8d0
Compare
aldanor
reviewed
Jun 27, 2021
| @@ -18,7 +18,10 @@ use crate::internal_prelude::*; | |||
|
|
|||
| lazy_static! { | |||
| static ref LIBRARY_INIT: () = { | |||
| h5lock!(::hdf5_sys::h5::H5open()); | |||
| h5lock!({ | |||
| ::hdf5_sys::h5::H5dont_atexit(); | |||
There was a problem hiding this comment.
Maybe a comment re: why this is here?
|
Looks good, thanks! Maybe a quick note in the changelog? |
|
Thanks @aldanor, I've added an entry to the changelog and a comment on the initialisation. |
|
Failure in CI/wine is unrelated to the current PR |
aldanor
approved these changes
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hdf5callingatexitcould create double free situations, where an orphaned thread would try to access a handle after it's been freed by the main thread.The functioncality disabled by this involves flushing data, closing objects, and cleaning up memory used. This is provided by
Dropby rust, and pure rust programs will not be affected by this change.In multi-language applications, care must be taken that all handles are closed by the programmer before program exit.
Fixes #159