Replace Array trait with const generics #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldanor
reviewed
Apr 7, 2021
|
By the way - the README still lists a wrong MSRV (In Compatibility/Rust section), might make sense to update that to 1.51 as well. Might also add a badge to the list of badges in readme, like  |
|
Looks good, all in all (few minor comments above aside) - thanks, happy to see those |
Co-authored-by: Ivan Smirnov <[email protected]>
aldanor
approved these changes
Apr 7, 2021
|
Thanks for the review! |
|
No problem :) // At some point, please add a "Required Rust compiler version is now 1.51" as the first line in "Changed" section of the changelog so it stands out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a layer of indirection and drops the
u8type from the string types. Introduces breaking changes, and would be nice to include in the next version.Fixes #143