Add support for _SQ64 on 32-bit architectures. #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be automatically detected so defining _SQ64 is now safe on 32-bit architectures. If it doesn't auto-detect (because you're using a compiler that doesn't have a _LP64-like define) the build will error (using a static assert in compilers that support it and a negative array size in compilers that don't) and you can fix this by defining _SQ64ON32 or _NOSQ64ON32 (depending on which direction it misdetected in). This means that a piece of software that is distributed on both 32 and 64 bit architectures can use a single set of compiled scripts, assuming the size of SQFloat and SQChar also match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be automatically detected so defining
_SQ64is now safe on 32-bit architectures. If it doesn't auto-detect (because you're using a compiler that doesn't have a_LP64-like define) the build will error (using a static assert in compilers that support it and a negative array size in compilers that don't) and you can fix this by defining_SQ64ON32or_NOSQ64ON32(depending on which direction it misdetected in).This means that a piece of software that is distributed on both 32 and 64 bit architectures can use a single set of compiled scripts, assuming the size of
SQFloatandSQCharalso match.