-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
40 transfer hpc #43
40 transfer hpc #43
Conversation
…versions of numpy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor comments.
haven't verified runs on HPC, let's pick this up next week.
@@ -1,5 +1,6 @@ | |||
num_attack_images: 1000 | |||
attack_names: ["L2FastGradientAttack","BoundaryAttack"] | |||
epsilons: [0.0, 0.1, 0.3, 0.5, 1.0] | |||
fga_epsilons: [0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of vals to try, what's the rough expected cost implication of each additional val? (for each attack)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in a test run on the HPC with the original five values (across 1000 images, 2x2=4 attacks) the script took 2 minutes 35 to run
Since once of these is 0, I'd assume about 40 seconds extra per (non-0) epsilon (while keeping the number of attack images and attacks constant)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run the tests locally, and they all passed. I can't see any issues in the code.
This PR resolves #40. It does this by implementing the following:
accelerator="auto"
is a lightning feature)