Skip to content

implemention of #311 tix api liquidation error fix #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

implemention of #311 tix api liquidation error fix #313

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35777f3
suggestion: custom scripts helper #292
samohtGTO May 19, 2023
48bbe11
Merge branch 'main' of https://github.com/samohtGTO/bitburner-scripts
samohtGTO Jul 1, 2023
ab71ebe
Ascend Without TIX API liquidate error
samohtGTO Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions autopilot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,10 @@ async function maybeInstallAugmentations(ns, player) {
setStatus(ns, `No singularity access, so you're on your own. You should manually work for factions and install augmentations!`);
return false; // Cannot automate augmentations or installs without singularity
}
const hasTixApiAccess = await getNsDataThroughFile(ns, 'ns.stock.hasTIXAPIAccess()');
if(!hasTixApiAccess) {
return false; //We cant liquidate
}
Copy link
Owner

@alainbryden alainbryden Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a bit aggressive - for example if we don't have TIXAPIAccess, but the user also just doesn't have any stocks, then we should be able to ascend normally because there's no fear of leaving stocks unsold / money unspent.

I think there's a separate API method that checks if we even have access to the stock market, so this could instead be something like:

if( hasStockMarketAccess && !hasTixApiAccess )
        setStatus(ns, `You have access to the stock market, but not the stock API! We will not ascend automatically, just in case you have some stock to sell...`);
        return false;

Also, the indentation is off here

// If we previously attempted to reserve money for an augmentation purchase order, do a fresh facman run to ensure it's still available
if (reservedPurchase && installCountdown <= Date.now()) {
log(ns, "INFO: Manually running faction-manager.js to ensure previously reserved purchase is still obtainable.");
Expand Down