Merged
Conversation
Fix JumpChargingAnimator choppy at end
alRex-U
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a proper end transition to the Slide animation, implementing the intent of #442
using the Animator system as a more robust solution.
For the Slide action:
The player's swimAmount is cleared when the action stops to eliminate interference from the vanilla swimming animation.
SlidingAnimator now applies a short inverse animation (5 ticks) after the action ends, creating a smoother visual transition instead of an abrupt stop.
Additionally, this PR fixes an issue in JumpChargingAnimator that caused the charging animation to become visually choppy near the end.
The root cause was improper handling of partial ticks after charging stopped:
The integer charging tick was decrementing as expected,
but the partial tick continued increasing,
resulting in inconsistent accumulated values and visible jitter.
This PR resolves the issue by reversing the partial tick progression when not charging, ensuring smooth interpolation during the release phase.