fix: branch-protection bypass actor + engines allowlist 加 glm #196

Activity

1. github-actions commented on Jul 22, 2026

   

   github-actionsbot

   on Jul 22, 2026 – with GitHub Actions

   Contributor

   More actions

   Thanks for this clear issue. Summary: (P1) remove the bypass_actors block from branch-protection.ts — the S7 pipeline-fix label is the sole branch-protection bypass, not a ruleset-level actor; (P2) add glm to ALLOWED_PROVIDERS in engines/actions.ts since GLM is the default passthrough. Your test plan looks solid — pnpm typecheck + pnpm test green, and the S7 reviewer confirm is a good call. Routing to development pipeline.
2. github-actions

   added

   triageNewly opened; awaiting triage botNewly opened; awaiting triage bot

   on Jul 22, 2026
3. akushonkamen commented on Jul 22, 2026

   

   akushonkamen

   on Jul 22, 2026

   OwnerAuthor

   More actions

   🤖 Claude self-acceptance (M8 workload=standard). accepted-by-claude applied — Module 4 develop-gate will pick this up. Maintainer may override with rejected.
4. akushonkamen

   added

   accepted-by-claudeClaude self-acceptance after clarify loop (Module 4 trigger, distinct from maintainer accepted)Claude self-acceptance after clarify loop (Module 4 trigger, distinct from maintainer accepted)

   verifyingModule 5 self-verify activeModule 5 self-verify active

   on Jul 22, 2026
5. DONKY-XOTE

   added a commit that references this issue on Jul 22, 2026

   fix(app): ConfigureStep JSX 引号转义 + 同步 S7 bypass 说明

   ...

   This issue will close once commit 245af43 is merged into the 'dev' branch.

   245af43
6. github-actions

   added

   stage:failedA module failed; needs maintainer triageA module failed; needs maintainer triage

   on Jul 22, 2026
7. github-actions commented on Jul 22, 2026

   

   github-actionsbot

   on Jul 22, 2026 – with GitHub Actions

   Contributor

   More actions

   ⚠️ Module 4 produced no new commits (issue #57).

   Claude analysed the issue and concluded no code change is required — pre-sha == post-sha, so no commit was made. Downstream modules (pr-lifecycle → verify) will NOT fire.

   Maintainer action required:

   • Re-triage the issue — the acceptance criteria may already be satisfied by existing code
   • OR refine the issue body and re-dispatch code-generate.yml
   • OR close as not-actionable

   Workflow run
8. akushonkamen

   added

   verifiedModule 5 self-verify passedModule 5 self-verify passed

   and removed

   verifyingModule 5 self-verify activeModule 5 self-verify active

   on Jul 22, 2026
9. akushonkamen commented on Jul 22, 2026

   

   akushonkamen

   on Jul 22, 2026

   OwnerAuthor

   More actions

   ✅ Verify passed — Module 6 (test) engaged. PR: #197
10. akushonkamen

    added

    testingModule 6 test activeModule 6 test active

    verifyingModule 5 self-verify activeModule 5 self-verify active

    and removed

    verifyingModule 5 self-verify activeModule 5 self-verify active

    on Jul 22, 2026
11. akushonkamen commented on Jul 22, 2026

    

    akushonkamen

    on Jul 22, 2026

    OwnerAuthor

    More actions

    ✅ Verify passed — Module 6 (test) engaged. PR: #197
12. akushonkamen

    added a commit that references this issue on Jul 22, 2026

    fix(app): branch-protection bypass actor 删除 + engines allowlist 加 glm

    ...

    This issue will close once commit 3b13531 is merged into the 'dev' branch.

    3b13531
13. akushonkamen

    closed this as completedin #197on Jul 22, 2026
14. akushonkamen

    added a commit that references this issue on Jul 22, 2026

    fix(app): ConfigureStep JSX 引号转义 + 同步 S7 bypass 说明

    ...

    This issue will close once commit 2816b4c is merged into the 'dev' branch.

    2816b4c
15. github-actions commented on Jul 22, 2026

    

    github-actionsbot

    on Jul 22, 2026 – with GitHub Actions

    Contributor

    More actions

    ❌ Test: failed

    Field	Value
    PR	#197
    Workflow run	https://github.com/akushonkamen/github-auto-dev-scaffold/actions/runs/29885066040

    Test framework: vitest v2.1.9

    Existing test suite: 19/19 passed, 3 files ✓
    ✓ deploy-pipeline.test.ts (10 tests)
    ✓ quota.test.ts (6 tests)
    ✓ stripe.test.ts (3 tests)

    Acceptance criteria coverage:
    ✗ P1: branch-protection.ts 删除 bypass_actors 块 (S7 合规修复) — NO COVERAGE
    (branch-protection.ts 没有任何测试; 现有 deploy-pipeline tests 只覆盖 parseLabelsYml, DEFAULT_VARS, diffVars)
    ✗ P2: engines/actions.ts ALLOWED_PROVIDERS 加 'glm' — NO COVERAGE
    (actions.ts 没有任何测试; ALLOWED_PROVIDERS set 和 provider 校验逻辑完全未测试)

    Outcome: 19/19 tests pass, but both P1 and P2 acceptance criteria have zero test coverage. 这是重大缺口: S7 合规修复和 glm provider 添加均未经测试验证。
16. akushonkamen

    added

    test:retry-1Auto-retry 1/3: re-running Module 4 with test feedbackAuto-retry 1/3: re-running Module 4 with test feedback

    and removed

    testingModule 6 test activeModule 6 test active

    verifiedModule 5 self-verify passedModule 5 self-verify passed

    on Jul 22, 2026
17. akushonkamen commented on Jul 22, 2026

    

    akushonkamen

    on Jul 22, 2026

    OwnerAuthor

    More actions

    🔄 Auto-retry 1/3

    Field	Value
    Retry	1 of 3
    Prior workflow run	https://github.com/akushonkamen/github-auto-dev-scaffold/actions/runs/29885066040
    Retry label	test:retry-1

    Failure summary (prior Module 6 run)

    Test framework: vitest v2.1.9

    Existing test suite: 19/19 passed, 3 files ✓
    ✓ deploy-pipeline.test.ts (10 tests)
    ✓ quota.test.ts (6 tests)
    ✓ stripe.test.ts (3 tests)

    ---

    code-generate.yml will auto-trigger on the test:retry-1 label,
    fetch this comment as the prior-test-report, and re-run Module 4 to
    fix the failure.
18. github-actions commented on Jul 22, 2026

    

    github-actionsbot

    on Jul 22, 2026 – with GitHub Actions

    Contributor

    More actions

    ⚠️ code-generate failed. See workflow run for details. A maintainer will triage manually.