Open
Conversation
Added code to read and print data from the first inflammation file with error handling for missing files. Implemented the patient_summary function to compute mean, max, and min using numpy, and updated detect_problems to warn if any patient has a mean inflammation of 0. Updated notebook metadata to reflect the current Python environment.
efantinatti
suggested changes
Dec 11, 2025
efantinatti
left a comment
There was a problem hiding this comment.
Hi @akorade Q1 is OK. Q2 you may consider running max and mean. Q3 you may also consider testing all the files and see which of them you get the True values.
Best,
E. Fantinatti
Enhanced the test code to check min, max, and mean array lengths for patient data. Updated the detect_problems test to execute for all the input files
Owner
Author
@efantinatti Added the test scenarios |
Owner
Author
|
@efantinatti Could you please reconfirm? |
efantinatti
approved these changes
Dec 11, 2025
efantinatti
left a comment
There was a problem hiding this comment.
Thanks @akorade I can see your changes now. All good. You can merge it to main.
Best
@efantinatti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added code to read and print data from the first inflammation file with error handling for missing files. Implemented the patient_summary function to compute mean, max, and min using numpy, and updated detect_problems to warn if any patient has a mean inflammation of 0. Updated notebook metadata to reflect the current Python environment.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I implemented three main functions for analyzing arthritis drug efficacy data:
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
For Question 1, I could have used the csv module instead of readlines():
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
NA
How were these changes tested?
I tested all changes locally using Jupyter Notebook in Visual Studio Code
A reference to a related issue in your repository (if applicable)
NA
Checklist