Open
Conversation
Added an anagram_checker function with case-insensitive and case-sensitive options. Updated notebook cells to include function implementation, test cases, and outputs. Changed kernel metadata to use Python 3.12.10.
Simplified the anagram_checker function by normalizing case at the start if case sensitivity is disabled, then sorting both words. This improves readability and reduces code duplication.
xindizhang
approved these changes
Dec 2, 2025
xindizhang
left a comment
There was a problem hiding this comment.
Excellent work! Your code is clean and well-written and your PR description is clear. Assignment 1 is complete – no changes needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I implemented an anagram checker function in two parts:
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I considered using a dictionary to count character frequencies instead of sorting, but decided sorting was simpler and more concise. Another approach could have been using Counter from the collections module:
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
NA
How were these changes tested?
I tested the changes locally using Jupyter Notebook in Visual Studio Code. I ran all code cells in the notebook assignment_1.ipynb
A reference to a related issue in your repository (if applicable)
NA
Checklist