Add CRL checks #1474
Merged
Add CRL checks #1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
reviewed
May 20, 2025
| @@ -66,7 +72,7 @@ public FileSystemVaultHandler( | |||
| : aliases -> null; | |||
|
|
|||
| FileSystemStoreInfo trust = supplyStoreInfo(resolvePath, options.trust); | |||
| supplyTrust = (aliases, cacerts) -> newTrustFactory(trust, aliases, cacerts); | |||
| supplyTrust = (aliases, cacerts, crlChecks) -> newTrustFactory(trust, aliases, cacerts, crlChecks); | |||
There was a problem hiding this comment.
This forced API change suggests that the decision to enforce CRL checks might belong in the vault, not the TLS binding, what do you think?
jfallows
requested changes
Jun 17, 2025
...ing-echo/src/test/java/io/aklivity/zilla/runtime/binding/echo/internal/bench/EchoWorker.java
Outdated
Show resolved
Hide resolved
...binding-tls/src/main/java/io/aklivity/zilla/runtime/binding/tls/config/TlsOptionsConfig.java
Outdated
Show resolved
Hide resolved
...ls/src/main/java/io/aklivity/zilla/runtime/binding/tls/internal/config/TlsBindingConfig.java
Outdated
Show resolved
Hide resolved
...inding-tls/src/test/java/io/aklivity/zilla/runtime/binding/tls/internal/bench/TlsWorker.java
Outdated
Show resolved
Hide resolved
| @@ -143,6 +144,7 @@ public class EngineConfiguration extends Configuration | |||
| ENGINE_CACERTS_STORE_PASS = config.property("cacerts.store.pass"); | |||
| ENGINE_ERROR_REPORTER = config.property(ErrorReporter.class, "error.reporter", | |||
| EngineConfiguration::decodeErrorReporter, EngineConfiguration::defaultErrorReporter); | |||
| ENGINE_REVOCATION = config.property("revocation"); | |||
There was a problem hiding this comment.
We need a name with more context for clarity.
Suggested change
| ENGINE_REVOCATION = config.property("revocation"); | |
| ENGINE_CERTIFICATE_REVOCATION_STRATEGY = config.property("certificate.revocation.strategy"); |
Suggest making this more strongly typed with an enum, say RevocationStrategy in io.aklivity.zilla.runtime.engine.security package.
public enum RevocationStrategy
{
CRL,
NONE
}
...and default to NONE.
We can also consider using this type (from lowercase string) in various vault options instead of string, encouraging consistency across different vault implementations.
...rc/main/java/io/aklivity/zilla/runtime/vault/filesystem/internal/FileSystemVaultHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/vault/filesystem/internal/FileSystemVaultHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/vault/filesystem/internal/FileSystemVaultHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/vault/filesystem/internal/FileSystemVaultHandler.java
Show resolved
Hide resolved
...m/src/test/java/io/aklivity/zilla/runtime/vault/filesystem/internal/FileSystemVaultTest.java
Outdated
Show resolved
Hide resolved
jfallows
reviewed
Jun 18, 2025
jfallows
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.