Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrong VersionVector when migrated from non-replicated #1304

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix: Wrong VersionVector when migrated from non-replicated #1304

merged 2 commits into from
Jan 24, 2025

Conversation

patriknw
Copy link
Member

  • it should be replicaId and not persistenceId

@patriknw
fix: Wrong VersionVector when migrated from non-replicated
7a0b908 
* it should be replicaId and not persistenceId
aludwiko
aludwiko approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@aludwiko aludwiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw
Copy link
Member Author

I have verified with the sample.

@patriknw patriknw merged commit 6ec48a0 into main Jan 24, 2025
22 checks passed
@patriknw patriknw deleted the wip-migrated-res-metadata-patriknw branch January 24, 2025 15:41
@patriknw patriknw added this to the 1.6.8 milestone Jan 24, 2025
@patriknw patriknw added the bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aludwiko aludwiko aludwiko approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.6.8
Development

Successfully merging this pull request may close these issues.
2 participants
@patriknw @aludwiko