fix: DynamoDB Timestamp validation of previous seqNr #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* base the validaiton time window for the previous sequence number on start timestamp and backtracking window
patriknw
commented
Nov 20, 2024
| // Backtracking will emit missed event again. | ||
| timestampOf(pid, seqNr - 1).map { | ||
| case Some(previousTimestamp) => | ||
| val before = currentState.latestTimestamp.minus(settings.timeWindow) |
There was a problem hiding this comment.
This latestTimestamp is not good for DynamoDB since each slice may progress more than others.
I don't really expect this to happen often with DynamoDB since we don't delete offsets in same way, but if we keep the check it's better that it's the same as in r2dbc.
patriknw
force-pushed
the
wip-timestamp-validation2-patriknw
branch
from
3180251 to
af8744c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on start timestamp and backtracking window
Corresponding to #1246