Skip to content

Commit

Permalink
Eslint prettier conflict fix (PalisadoesFoundation#1837)
Browse files Browse the repository at this point in the history
* fix eslint config for conflict

* Update linting and formatting scripts in package.json
  • Loading branch information
pranshugupta54 committed Mar 29, 2024
1 parent 68db1fb commit 259e65b
Show file tree
Hide file tree
Showing 3 changed files with 647 additions and 266 deletions.
23 changes: 10 additions & 13 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"plugin:jest/recommended",
"plugin:prettier/recommended",
"plugin:@typescript-eslint/recommended",
"eslint-config-prettier",
"prettier"
],
"globals": {
Expand All @@ -33,7 +34,8 @@
"@typescript-eslint",
"jest",
"import",
"eslint-plugin-tsdoc"
"eslint-plugin-tsdoc",
"prettier"
],
"rules": {
"react/destructuring-assignment": "error",
Expand Down Expand Up @@ -110,7 +112,11 @@
"leadingUnderscore": "require"
},

{ "selector": "variable", "modifiers": ["exported"], "format": null }
{
"selector": "variable",
"modifiers": ["exported"],
"format": null
}
],
// Ensures that components are always written in PascalCase
"react/jsx-pascal-case": [
Expand All @@ -125,22 +131,13 @@
// All tests must need not have an assertion
"jest/expect-expect": 0,

"react/jsx-indent": ["error", 2],
"react/jsx-tag-spacing": [
"warn",
{
"afterOpening": "never",
"beforeClosing": "never",
"beforeSelfClosing": "always"
}
],

// Enforce Strictly functional components
"react/no-unstable-nested-components": ["error", { "allowAsProps": true }],
"react/function-component-definition": [
0,
{ "namedComponents": "function-declaration" }
]
],
"prettier/prettier": "error"
},

// Let ESLint use the react version in the package.json
Expand Down
Loading

0 comments on commit 259e65b

Please sign in to comment.