-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft issue and PR templates. #32
base: master
Are you sure you want to change the base?
Conversation
Includes `Bug Report`, `Bug Report Form`, `Feature Request` and a PR template.
Any suggestions for enhancing the templates? |
- [ ] I have read the [CONTRIBUTING]() guide. | ||
- [ ] My code follows the [code style]() of this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder: need to add links
Co-authored-by: Antti Kaihola <[email protected]>
This configures that two contact links to the discussions and the docs will be displayed alongside the issue forms. * .github/ISSUE_TEMPLATE/config.yml
I configured so called contact links that will be listed below the issue forms. |
No need to duplicate Issue Forms with Issue Templates. Just use Issue Forms (yaml files). |
@webknjaz does this mean that this PR can just be closed? |
Why? Just don't add templates, keep the forms. |
Oops, indeed. So remove |
Yes, though it's probably useful to have several forms for different cases. Not just bugs. But it's up to you. I just wanted to point out that weird duplicate. |
* .github/ISSUE_TEMPLATE/config.yml Co-authored-by: Antti Kaihola <[email protected]>
Since issue forms are in beta still and I havened seen them used much yet, I decided to keep the option of the classic issue template which might be preferred by many people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see both
.github/ISSUE_TEMPLATE/bug_form.yaml
and
.github/ISSUE_TEMPLATE/bug_report.md
Aren't these the same thing both as a form and as a template, as pointed out by @webknjaz earlier?
I am no working on this PR or this repo in general. Anyone can pickup where I left of.
Yes, they are. |
I've been using forms since before they've gone public, in a private beta. It's been a long time. They are quite stable. Here's an example: https://github.com/ansible/ansible/issues/new/choose. |
Includes
Bug Report
,Bug Report Form
,Feature Request
and a PR template.This is still a draft since other part of the documentation have to be finished before the templates can be completed.