-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update nushell init script #966
Conversation
c770a05
to
3fe42e9
Compare
I currently have an issue with the generated nushell script. It seems instead of
it must be
Note the added Should I make a PR for this or is this PR going to merged? |
Is it ionly my problem that zoxide stopped adding paths to it's db? |
@KamilKleina not at all, the only way it works is using |
@KamilKleina FIXED !! this is my commit for my personal configs which solve the issue for now until a proper fix !! zoxide adds new paths and everything. Enjoy ! |
Thanks! Loving the new Nushell syntax :) |
__zoxide_z
more idiomaticTo expand on hook initialization:
After nushell/nushell#14704 (comment), starting sub shells would make zoxide's init script throw an error.
With this PR
$env.__zoxide_hooked
is no longer used. Instead, the list of hooks are checked directly to see if zoxide's hook has already been added.I checked the new init script on both nushell version 0.89.0 and the latest nushell nightly.
Minimum supported version of nushell doesn't need to change and can be kept at 0.89.0