added downloadurl parameter to support pulling the binary from a remo…#9
Open
ozkatz wants to merge 1 commit intoajcurated:masterfrom
ozkatz:master
Open
added downloadurl parameter to support pulling the binary from a remo…#9ozkatz wants to merge 1 commit intoajcurated:masterfrom ozkatz:master
ozkatz wants to merge 1 commit intoajcurated:masterfrom
ozkatz:master
Conversation
Owner
|
Hi @ozkatz this looks like a good addition, could you fix the linting issues and format the class params the same as the others and it might be worth adding a Then I'll merge this in! |
Owner
|
Hi @ozkatz keen to merge this if you can fix the above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added another parameter called
downloadurl, which if set, will attempt to pull the binary from a URL. This is done mostly in order to avoid placing confd's binary inside the site module.Once set, wget will be used to pull the binary - unless it already exists and
confd --versionreports the same version number as set by$confd::version.Tested this on CentOS 6.5 and Ubuntu 14.04.