Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 複数行コメントの*/がないと文法エラーが出るように #887

Merged
merged 3 commits into from
Jan 3, 2025
Merged

fix: 複数行コメントの*/がないと文法エラーが出るように #887

merged 3 commits into from
Jan 3, 2025

Conversation

takejohn
Copy link
Contributor

What

複数行コメントを*/で閉じないと「unexpected EOF」の文法エラーが出るようにします。

Why

Additional info (optional)

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/parser/scanner.ts 94.89% <100.00%> (+6.12%) ⬆️

... and 29 files with indirect coverage changes

uzmoi
uzmoi reviewed Jan 1, 2025
View reviewed changes
Copy link
Member

@uzmoi uzmoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

パーサーが変わるのが1.0.0なのでchangelog無くていいと思います

@takejohn
Copy link
Contributor Author

takejohn commented Jan 1, 2025

パーサーが変わるのが1.0.0なのでchangelog無くていいと思います

確かに0.19.0ではエラーになりますね。
CHANGELOGを削除しました。

@takejohn takejohn merged commit 97b9d15 into aiscript-dev:master Jan 3, 2025
4 checks passed
@takejohn takejohn deleted the fix/876_comment-range-invalid-eof branch January 3, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzmoi uzmoi uzmoi approved these changes

@FineArchs FineArchs FineArchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

複数行コメントの途中でEOFになってもエラーにならない
4 participants
@takejohn @codecov-commenter @uzmoi @FineArchs