Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docsと同じ型注釈を行えるようにする #870

Merged

Conversation

takejohn
Copy link
Contributor

@takejohn takejohn commented Dec 2, 2024

What

関数宣言および関数型でのジェネリクスと、ユニオン型、error型、never型の型注釈ができるようになります。

Why

Additional info (optional)

common.tsから型注釈のパースを行う関数をtypes.tsに切り出しました。

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.59664% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/type.ts 68.18% 14 Missing ⚠️
src/parser/syntaxes/types.ts 96.33% 4 Missing ⚠️
src/parser/plugins/validate-keyword.ts 88.88% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/interpreter/index.ts 94.84% <100.00%> (+9.04%) ⬆️
src/node.ts 85.71% <ø> (-12.66%) ⬇️
src/parser/plugins/validate-type.ts 100.00% <100.00%> (+17.64%) ⬆️
src/parser/scanner.ts 94.52% <100.00%> (+5.75%) ⬆️
src/parser/syntaxes/common.ts 96.58% <100.00%> (+7.05%) ⬆️
src/parser/syntaxes/expressions.ts 94.82% <100.00%> (+5.63%) ⬆️
src/parser/syntaxes/statements.ts 97.41% <100.00%> (+4.15%) ⬆️
src/parser/token.ts 100.00% <100.00%> (ø)
src/parser/visit.ts 100.00% <100.00%> (+5.26%) ⬆️
src/parser/plugins/validate-keyword.ts 97.12% <88.88%> (+8.50%) ⬆️
... and 2 more

... and 19 files with indirect coverage changes

@takejohn takejohn merged commit d25808e into aiscript-dev:master Dec 21, 2024
4 checks passed
@takejohn takejohn deleted the feat/856_unified-type-annotation branch December 21, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docsと同じ型注釈を実際に行えるようにする
4 participants