⚡️ Speed up method StreamAvailabilityStrategy.check_availability by 9% in PR #45673 (async-job-salesforce/cdk-release)

[codeflash-ai]

⚡️ This pull request contains optimizations for PR #45673

If you approve this dependent PR, these changes will be merged into the original PR branch async-job-salesforce/cdk-release.

This PR will be automatically closed if the original PR is merged.

---

📄 StreamAvailabilityStrategy.check_availability() in airbyte-cdk/python/airbyte_cdk/sources/streams/concurrent/adapters.py

📈 Performance improved by 9% (0.09x faster)

⏱️ Runtime went down from 29.5 microseconds to 27.0 microseconds

Explanation and details

Certainly! Here is an optimized version of the given code. The primary optimization focuses on reducing redundant checks and making use of exception handling in a more efficient manner.

Optimizations made.

1. Reduced Redundant Calls:

   • hasattr and callable combined into a single conditional check.
   • Checked for method existence and direct callability within the try block.

2. Exception Handling.

   • Moved the ExceptionWithDisplayMessage raising to a more concise single line using the ternary operator.

Explanation.

1. Conditional Check: Combining hasattr and callable ensures that check_availability method existence and callability are checked in a streamlined manner.
2. Exception Handling Clarity: Using a ternary operator for raising ExceptionWithDisplayMessage or re-raising the caught exception makes the code more readable and slightly faster due to less branching.

Correctness verification

The new optimized code was tested for correctness. The results are listed below.

✅ 1 Passed − ⚙️ Existing Unit Tests

(click to show existing tests)

- sources/streams/concurrent/test_adapters.py

✅ 0 Passed − 🌀 Generated Regression Tests

(click to show generated tests)

# imports
import logging
from abc import ABC, abstractmethod
from typing import Any, Optional

import pytest  # used for our unit tests
from airbyte_cdk.sources import Source
from airbyte_cdk.sources.streams import Stream
from airbyte_cdk.sources.streams.concurrent.adapters import \
    StreamAvailabilityStrategy
from airbyte_cdk.sources.streams.concurrent.availability_strategy import \
    AbstractAvailabilityStrategy

# unit tests

# Test Stream with `check_availability` Method Returning Available

🔘 (none found) − ⏪ Replay Tests

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 19, 2024 4:40pm

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}