Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python CDK: Bump jsonschema and pendulum dependencies #45677

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Udit107710
Copy link

What

  • Support for Prefect 3
  • Bump up jsonschema and pendulum to support Prefect 3
  • Issue

How

  • Upgrade to new versions
  • Fix breaking changes from the newer versions

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@Udit107710 Udit107710 marked this pull request as draft September 19, 2024 16:01
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 4:01pm

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Sep 19, 2024
@aaronsteers aaronsteers changed the title ✨ Support for Prefect 3 Python CDK: Bump jsonschema and pendulum dependencies Sep 23, 2024
@aaronsteers
Copy link
Collaborator

aaronsteers commented Sep 24, 2024

@Udit107710 - aside from tests, did you find any breaking changes in Pendulum 3.0?

If not, could we (at least here in the CDK) keep support for the latest 2.x version of Pendulum as well as 3.0?

I'm wary of boxing people out of PyAirbyte if they are using something that still has a 2.x dependency, and I don't think Pendulum 3.0 adoption has been promoted as a high priority in other libraries/tools.

Lmk what you think. Thanks!

@Udit107710
Copy link
Author

I don't think keeping support for both the versions would be possible. Take a look at the changelog here. The changes in pendulum are not backwards compatible.
Even after reading the changelog if you still feel that we should test it out once, I will do so.

@Udit107710 Udit107710 mentioned this pull request Sep 30, 2024
1 task
@Udit107710
Copy link
Author

@aaronsteers What do you think about the above comment?

@s0ham075
Copy link

How did you manage to point airbyte towards your forked repo? I am also trying to do something similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants