-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python CDK: Bump jsonschema
and pendulum
dependencies
#45677
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jsonschema
and pendulum
dependencies
@Udit107710 - aside from tests, did you find any breaking changes in Pendulum 3.0? If not, could we (at least here in the CDK) keep support for the latest 2.x version of Pendulum as well as 3.0? I'm wary of boxing people out of PyAirbyte if they are using something that still has a 2.x dependency, and I don't think Pendulum 3.0 adoption has been promoted as a high priority in other libraries/tools. Lmk what you think. Thanks! |
I don't think keeping support for both the versions would be possible. Take a look at the changelog here. The changes in pendulum are not backwards compatible. |
@aaronsteers What do you think about the above comment? |
How did you manage to point airbyte towards your forked repo? I am also trying to do something similar |
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?