⚡️ Speed up method Timer.finish by 47% in PR #45125 (tolik0/airbyte-cdk/add-per-partition-with-global-fallback)

[codeflash-ai]

⚡️ This pull request contains optimizations for PR #45125

If you approve this dependent PR, these changes will be merged into the original PR branch tolik0/airbyte-cdk/add-per-partition-with-global-fallback.

This PR will be automatically closed if the original PR is merged.

---

📄 Timer.finish() in airbyte-cdk/python/airbyte_cdk/sources/declarative/incremental/global_substream_cursor.py

📈 Performance improved by 47% (0.47x faster)

⏱️ Runtime went down from 64.0 microseconds to 43.5 microseconds

Explanation and details

To optimize the given Python program, we can make the following changes.

Correctness verification

The new optimized code was tested for correctness. The results are listed below.

🔘 (none found) − ⚙️ Existing Unit Tests

✅ 14 Passed − 🌀 Generated Regression Tests

(click to show generated tests)

# imports
import threading
import time
# function to test
from typing import Optional

import pytest  # used for our unit tests
from airbyte_cdk.sources.declarative.incremental.global_substream_cursor import \
    Timer

# unit tests

# Basic Functionality
def test_timer_basic_functionality():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    time.sleep(1)
    codeflash_output = timer.finish()

    timer._start = time.perf_counter_ns()
    time.sleep(0.5)
    codeflash_output = timer.finish()
    # Outputs were verified to be equal to the original implementation

# Edge Cases
def test_timer_not_started():
    timer = Timer()
    with pytest.raises(RuntimeError, match="Global substream cursor timer not started"):
        timer.finish()
    # Outputs were verified to be equal to the original implementation

# Precision and Rounding
def test_timer_exact_second():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    time.sleep(1)
    codeflash_output = timer.finish()
    # Outputs were verified to be equal to the original implementation

def test_timer_fractional_second():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    time.sleep(1.999)
    codeflash_output = timer.finish()
    # Outputs were verified to be equal to the original implementation

# Performance and Scalability
def test_timer_long_duration():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    time.sleep(10)
    codeflash_output = timer.finish()
    # Outputs were verified to be equal to the original implementation

def test_timer_high_resolution():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    time.sleep(0.000001)
    codeflash_output = timer.finish()
    # Outputs were verified to be equal to the original implementation

# Boundary Conditions
def test_timer_near_boundary_values():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    time.sleep(0.999999999)
    codeflash_output = timer.finish()

    timer._start = time.perf_counter_ns()
    time.sleep(1.000000001)
    codeflash_output = timer.finish()
    # Outputs were verified to be equal to the original implementation

# Multiple Calls
def test_timer_sequential_calls():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    time.sleep(1)
    codeflash_output = timer.finish()

    with pytest.raises(RuntimeError, match="Global substream cursor timer not started"):
        timer.finish()
    # Outputs were verified to be equal to the original implementation

# Rare or Unexpected Edge Cases

# System Clock Changes (Note: perf_counter_ns is not affected by system clock changes, but these tests are included for completeness)
def test_timer_system_clock_adjusted_backwards():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    # Simulate system clock adjustment backwards
    time.sleep(1)
    codeflash_output = timer.finish()
    # Outputs were verified to be equal to the original implementation

def test_timer_system_clock_adjusted_forwards():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    # Simulate system clock adjustment forwards
    time.sleep(1)
    codeflash_output = timer.finish()
    # Outputs were verified to be equal to the original implementation

# Timer Restart
def test_timer_restarted_without_resetting():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    time.sleep(1)
    timer._start = time.perf_counter_ns()  # Restart timer
    time.sleep(0.5)
    codeflash_output = timer.finish()
    # Outputs were verified to be equal to the original implementation

# Extreme Durations
def test_timer_extremely_short_duration():
    timer = Timer()
    timer._start = time.perf_counter_ns()
    codeflash_output = timer.finish()  # Called immediately
    # Outputs were verified to be equal to the original implementation

🔘 (none found) − ⏪ Replay Tests

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 19, 2024 2:59pm

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}