feat(source-gcs): add support for zip files #45671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
artem1205
requested changes
Sep 19, 2024
airbyte-integrations/connectors/source-gcs/source_gcs/stream.py
Outdated
Show resolved
Hide resolved
2 tasks
artem1205
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
resolved: https://github.com/airbytehq/airbyte-internal-issues/issues/8949
could not set up source for zip files
How
smart_open, which source uses for opening files, doesn't support .zip compression. For reading zip files unzipping into a temporary folder was added. Then source uses path to it as uri to remote file. GCSRemoteFile is used to avoid using temp path in state and record values for uri field.Review guide
airbyte-integrations/connectors/source-gcs/source_gcs/stream_reader.pyairbyte-integrations/connectors/source-gcs/source_gcs/helpers.pyairbyte-integrations/connectors/source-gcs/source_gcs/cursor.pyairbyte-integrations/connectors/source-gcs/source_gcs/stream.pyUser Impact
Can this PR be safely reverted and rolled back?