-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commcare connector changes #45652
base: master
Are you sure you want to change the base?
commcare connector changes #45652
Conversation
Deployment failed with the following error:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
The code looks reasonable. I'll kick-off the CI, and I wonder if we could move this to be a low-code connector and just add field transformations to drop the columns the user doesn't need instead of having custom python code. But, /shrug
@natikgadzhi can you let me know if there are any other changes required ? |
/format-fix
|
@Ishankoradia is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
@natikgadzhi fixed the format issues. |
@Ishankoradia our CI can't push changes back to your branch ;( I think it's a setting on the PR to allow admins to make changes to it. Please toggle it, I'll run /format-fix after and get this merged. |
@natikgadzhi where is this setting that I am suppose to toggle ? |
Signed-off-by: Ishankoradia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd need to bump the version of the connector:
pyproject.toml
metadata.yaml
(dockerImageTag)- docs/integrations/sources/commcare.md
@@ -1,8 +1,7 @@ | |||
# | |||
# Copyright (c) 2023 Airbyte, Inc., all rights reserved. | |||
# Copyright (c) 2022 Airbyte, Inc., all rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmmmmmm that's not all that relevant, but we probably don't want to change this back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like your forked branch was outdated.
What
Ability to exclude form fields while pulling data
How
Review guide
User Impact
An extra field in the source configuration while adding the connector
Can this PR be safely reverted and rolled back?