Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk Load CDK: Add integration test using in-memory mock destination #45634

Draft
wants to merge 1 commit into
base: edgao/spec_test
Choose a base branch
from
Draft

Bulk Load CDK: Add integration test using in-memory mock destination #45634

wants to merge 1 commit into from
+117 −3

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Sep 17, 2024 •
edited
Loading

Add "integration tests" for the CDK, which test full syncs/etc. against an in-memory destination.

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:00pm

This was referenced Sep 17, 2024
Open
Open
Open
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Sep 17, 2024
This was referenced Sep 17, 2024
Open
Open
@edgao Graphite App
Copy link
Contributor Author

edgao commented Sep 17, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

This was referenced Sep 17, 2024
Open
Open
edgao
edgao commented Sep 18, 2024
View reviewed changes
airbyte-cdk/bulk/core/load/src/test/kotlin/io/airbyte/cdk/command/MockCatalogFactory.kt
@Requires(env = ["test"])
//@Factory
//@Replaces(factory = DestinationCatalogFactory::class)
//@Requires(env = ["test"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnny-schmidt I did this yesterday as a quick hack just to get the test to run (otherwise micronaut threw a duplicate bean error). I think the easiest solution is to add another env to the Requires clause? @Requires(env=["test", "mock_catalog_factory"]) and then add that new env to all the tests that rely on this bean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could also add some Requires thing to the MockDestinationWrite, but then I'd need to plumb it down to the CliRunner

(... I could also move this stuff to testIntegration and wire up a proper integration test task 🤷 no strong opinion. But I do think it would be nice for the MockCatalogFactory to be an explicit opt-in)

edgao
edgao commented Sep 18, 2024
View reviewed changes
airbyte-cdk/bulk/core/load/src/test/resources/metadata.yaml
@@ -0,0 +1,4 @@
---
data:
dockerRepository: "airbyte/fake-source"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update this file, it's needed to make something in the connector runner happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgao @octavia-squidington-iii