Skip to content

Add editorconfig #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2016
+17 −0
Merged

Add editorconfig #1102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .editorconfig
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
root = true

[*]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is *, then the editorconfig check should also use * - if it's just js/jsx, then i'd like both places to match.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point

indent_style = space
indent_size = 2
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
end_of_line = lf
# editorconfig-tools is unable to ignore longs strings or urls
max_line_length = null
1 change: 1 addition & 0 deletions packages/eslint-config-airbnb-base/.editorconfig
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../.editorconfig
2 changes: 2 additions & 0 deletions packages/eslint-config-airbnb-base/package.json
View file
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
"description": "Airbnb's base JS ESLint config, following our styleguide",
"main": "index.js",
"scripts": {
"prelint": "editorconfig-tools check * rules/* test/*",
"lint": "eslint .",
"tests-only": "babel-tape-runner ./test/test-*.js",
"prepublish": "(in-install || eslint-find-rules --unused) && (not-in-publish || npm test) && safe-publish-latest",
@@ -47,6 +48,7 @@
"devDependencies": {
"babel-preset-airbnb": "^2.1.1",
"babel-tape-runner": "^2.0.1",
"editorconfig-tools": "^0.1.1",
"eslint": "^3.12.1",
"eslint-find-rules": "^1.14.3",
"eslint-plugin-import": "^2.2.0",
1 change: 1 addition & 0 deletions packages/eslint-config-airbnb/.editorconfig
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../.editorconfig
2 changes: 2 additions & 0 deletions packages/eslint-config-airbnb/package.json
View file
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
"description": "Airbnb's ESLint config, following our styleguide",
"main": "index.js",
"scripts": {
"prelint": "editorconfig-tools check * rules/* test/*",
"lint": "eslint .",
"tests-only": "babel-tape-runner ./test/test-*.js",
"prepublish": "(in-install || eslint-find-rules --unused) && (not-in-publish || npm test) && safe-publish-latest",
@@ -50,6 +51,7 @@
"devDependencies": {
"babel-preset-airbnb": "^2.1.1",
"babel-tape-runner": "^2.0.1",
"editorconfig-tools": "^0.1.1",
"eslint": "^3.12.1",
"eslint-find-rules": "^1.14.3",
"eslint-plugin-import": "^2.2.0",