This repository was archived by the owner on Feb 9, 2026. It is now read-only.
feat: Initial content for OCI to create the cve-checker image based on trivy#1
Open
adrianriobo wants to merge 1 commit into
Open
feat: Initial content for OCI to create the cve-checker image based on trivy#1adrianriobo wants to merge 1 commit into
adrianriobo wants to merge 1 commit into
Conversation
…n trivy Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
| skopeo copy --insecure-policy "docker://${TARGET_IMAGE}" "oci:${TARGET_IMAGE_PATH}:latest" | ||
| # Analyze | ||
| mkdir /compare | ||
| pushd /compare |
There was a problem hiding this comment.
any reason not to simply use cd here ? I don't understand why we use pushd, maybe a code style thing but I would make it obvious with cd
Contributor
Author
There was a problem hiding this comment.
nop I just get use to it, as it is easy for going back when you jump to diff paths (pushd / popd)
| fi | ||
|
|
||
| if [[ -n "${AUTH_USER:-}" && -n "${AUTH_PASS:-}" && -n "${AUTH_REG:-}" ]]; then | ||
| echo "$AUTH_PASS" | skopeo login --username "$AUTH_USER" --password-stdin "$AUTH_REG" |
There was a problem hiding this comment.
nitpick
Suggested change
| echo "$AUTH_PASS" | skopeo login --username "$AUTH_USER" --password-stdin "$AUTH_REG" | |
| skopeo login --username "$AUTH_USER" --password-stdin "$AUTH_REG" <<< "$AUTH_PASS" |
| # Get Images | ||
| BASE_IMAGE_PATH=/base | ||
| TARGET_IMAGE_PATH=/target | ||
| skopeo copy --insecure-policy "docker://${BASE_IMAGE}" "oci:${BASE_IMAGE_PATH}:latest" |
There was a problem hiding this comment.
what do we need this for ? --insecure-policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes an initial commit to create an OCI image based on Trivy which is able to compare 2 images (base and target) in order to generate 2 files: