-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getNrgPrice Java API call #500
Conversation
@aionick formatter seems to be taking up most of the code changes, possible for you to point out the specific sections with meaning edits? Also some of the formatting is problematic especially when it concerns lambdas |
My bad I had written that out and meant to comment but forgot. ApiAion0 is the only thing I manually changed here, lines 633-661, the case: Message.Funcs.f_getNrgPrice_VALUE |
NrgOracle.Strategy oracleStrategy = NrgOracle.Strategy.SIMPLE; | ||
|
||
this.nrgOracle = new NrgOracle(bc, nrgPriceDefault, nrgPriceMax, oracleStrategy); | ||
long nrg = this.getRecommendedNrgPrice(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Web3Aion has the same logic, please considering move the NrgOracle logic in both web3 and java api to the abstract class ApiAion
Description
Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.
Fixes Issue # N/A.
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.
Verification
Insert x into the following checkboxes to confirm (eg. [x]):