-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for _multidict_base.py #936
Conversation
@webknjaz if I'm not wrong using |
@a5r0n thanks for starting this effort! Those operators shouldn't cause problems in pytest. However, linters (like flake8) will be unhappy about unassigned expressions. To address that, use |
Oh, and the current CI failures don't seem to be related to your patch. They'll require addressing separately. I'll have to take a look myself. You'll need to rebase your PR branch at some point, once that's fixed. P.S. Here's a recommendation for the future PRs on GitHub: https://hynek.me/articles/pull-requests-branch/. |
This comment was marked as resolved.
This comment was marked as resolved.
`NotImplemented` and `Iterable` but not `Set` for `and, or, sub, xor`
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Signed-off-by: a5r0n <[email protected]>
Signed-off-by: a5r0n <[email protected]>
Signed-off-by: a5r0n <[email protected]>
@a5r0n I clicked "rebase" so this PR picks up the CI fixes. |
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Signed-off-by: a5r0n <[email protected]>
Signed-off-by: a5r0n <[email protected]>
NotImplemented
andIterable
but notSet
for_viewbaseset_{and, or, sub, xor}
Partially addresses #921.