Skip to content

Conversation

Dreamsorcerer
Copy link
Member

I think all of these no cover comments shouldn't exist.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport:skip Skip backport bot labels Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 98.69%. Comparing base (094bf4e) to head (b2c1c06).
Report is 3007 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
aiohttp/client_reqrep.py 0.00% 0 Missing and 2 partials ⚠️
aiohttp/pytest_plugin.py 50.00% 1 Missing and 1 partial ⚠️
aiohttp/compression_utils.py 0.00% 1 Missing ⚠️
aiohttp/helpers.py 0.00% 1 Missing ⚠️
aiohttp/http_parser.py 50.00% 0 Missing and 1 partial ⚠️
aiohttp/tcp_helpers.py 0.00% 1 Missing ⚠️
aiohttp/web_urldispatcher.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10455      +/-   ##
==========================================
+ Coverage   98.06%   98.69%   +0.63%     
==========================================
  Files         123      122       -1     
  Lines       37331    37180     -151     
  Branches     4504     2058    -2446     
==========================================
+ Hits        36608    36695      +87     
+ Misses        542      338     -204     
+ Partials      181      147      -34     
Flag Coverage Δ
CI-GHA 98.58% <62.96%> (+0.62%) ⬆️
OS-Linux 98.24% <51.85%> (+0.58%) ⬆️
OS-Windows 96.18% <59.25%> (+1.47%) ⬆️
OS-macOS 97.37% <48.14%> (+0.57%) ⬆️
Py-3.10.11 97.27% <62.96%> (+0.61%) ⬆️
Py-3.10.16 97.82% <48.14%> (+1.30%) ⬆️
Py-3.11.11 97.89% <48.14%> (+1.28%) ⬆️
Py-3.11.9 97.36% <62.96%> (+3.02%) ⬆️
Py-3.12.8 98.36% <62.96%> (+0.64%) ⬆️
Py-3.13.1 98.35% <62.96%> (+0.61%) ⬆️
Py-3.9.13 97.16% <62.96%> (+0.58%) ⬆️
Py-3.9.21 97.69% <48.14%> (+0.55%) ⬆️
Py-pypy7.3.16 97.29% <51.85%> (?)
VM-macos 97.37% <48.14%> (+0.57%) ⬆️
VM-ubuntu 98.24% <51.85%> (+0.58%) ⬆️
VM-windows 96.18% <59.25%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #10455 will improve performances by 35.25%

Comparing no-cover (b2c1c06) with master (343c632)

Summary

⚡ 2 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_one_hundred_get_requests_iter_chunks_on_512kib_chunked_payload[pyloop] 130.7 ms 96.7 ms +35.25%
test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop] 188.5 ms 166.1 ms +13.53%

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general except two replacements.

@Dreamsorcerer Dreamsorcerer merged commit 97f5e2d into master Feb 11, 2025
39 of 40 checks passed
@Dreamsorcerer Dreamsorcerer deleted the no-cover branch February 11, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants