Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup questionable no cover comments #10455

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Cleanup questionable no cover comments #10455

merged 5 commits into from
Feb 11, 2025

Conversation

Dreamsorcerer
Copy link
Member

I think all of these no cover comments shouldn't exist.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport:skip Skip backport bot labels Feb 11, 2025
aiohttp/web.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 98.69%. Comparing base (343c632) to head (b2c1c06).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
aiohttp/client_reqrep.py 0.00% 0 Missing and 2 partials ⚠️
aiohttp/pytest_plugin.py 50.00% 1 Missing and 1 partial ⚠️
aiohttp/compression_utils.py 0.00% 1 Missing ⚠️
aiohttp/helpers.py 0.00% 1 Missing ⚠️
aiohttp/http_parser.py 50.00% 0 Missing and 1 partial ⚠️
aiohttp/tcp_helpers.py 0.00% 1 Missing ⚠️
aiohttp/web_urldispatcher.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10455      +/-   ##
==========================================
- Coverage   98.76%   98.69%   -0.07%     
==========================================
  Files         122      122              
  Lines       37142    37180      +38     
  Branches     2046     2058      +12     
==========================================
+ Hits        36682    36695      +13     
- Misses        320      338      +18     
- Partials      140      147       +7     
Flag Coverage Δ
CI-GHA 98.58% <62.96%> (-0.07%) ⬇️
OS-Linux 98.24% <51.85%> (-0.09%) ⬇️
OS-Windows 96.18% <59.25%> (-0.07%) ⬇️
OS-macOS 97.37% <48.14%> (-0.10%) ⬇️
Py-3.10.11 97.27% <62.96%> (-0.08%) ⬇️
Py-3.10.16 97.82% <48.14%> (-0.10%) ⬇️
Py-3.11.11 97.89% <48.14%> (-0.11%) ⬇️
Py-3.11.9 97.36% <62.96%> (-0.06%) ⬇️
Py-3.12.8 98.36% <62.96%> (-0.07%) ⬇️
Py-3.13.1 98.35% <62.96%> (-0.07%) ⬇️
Py-3.9.13 97.16% <62.96%> (-0.07%) ⬇️
Py-3.9.21 97.69% <48.14%> (-0.10%) ⬇️
Py-pypy7.3.16 97.29% <51.85%> (-0.09%) ⬇️
VM-macos 97.37% <48.14%> (-0.10%) ⬇️
VM-ubuntu 98.24% <51.85%> (-0.09%) ⬇️
VM-windows 96.18% <59.25%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #10455 will improve performances by 35.25%

Comparing no-cover (b2c1c06) with master (343c632)

Summary

⚡ 2 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_one_hundred_get_requests_iter_chunks_on_512kib_chunked_payload[pyloop] 130.7 ms 96.7 ms +35.25%
test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop] 188.5 ms 166.1 ms +13.53%

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general except two replacements.

aiohttp/client_reqrep.py Outdated Show resolved Hide resolved
@Dreamsorcerer Dreamsorcerer merged commit 97f5e2d into master Feb 11, 2025
39 of 40 checks passed
@Dreamsorcerer Dreamsorcerer deleted the no-cover branch February 11, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants