-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Cleanup questionable no cover comments #10455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10455 +/- ##
==========================================
+ Coverage 98.06% 98.69% +0.63%
==========================================
Files 123 122 -1
Lines 37331 37180 -151
Branches 4504 2058 -2446
==========================================
+ Hits 36608 36695 +87
+ Misses 542 338 -204
+ Partials 181 147 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10455 will improve performances by 35.25%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general except two replacements.
I think all of these no cover comments shouldn't exist.