Skip to content

add msgspec #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add msgspec #1031

wants to merge 2 commits into from

Conversation

Vizonex
Copy link

@Vizonex Vizonex commented Jul 16, 2025

What do these changes do?

I saw that this library was using msgspack so I felt like adding something of my own as well. Msgspec is one of the fastest python dataclass libraries out there because it's written in C and with it having it's own msgspack protocol I decided to add in an encoder and decoder.

Are there changes in behavior for the user?

I attempeted to make sure that my end was properly typehinted.
I'm going to convert this into a draft for now but hopefully maybe I can turn it into a real pull request.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Dreamsorcerer
Copy link
Member

I'm not sure we want to be adding more dependencies here. As per other requests for new backends, we should probably put any other serializer in a new library (or a component in the parent library, if they're interested) and have it maintained there.

At the same time, a user wanting this could just implement the custom serializer in a couple of lines of code..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants