Use only one global var for marking config folder tree

[unkcpz]

The problem is found when I worked on #6609. If the import of DAEMON_DIR moved to outside the function, the global var set in module scope and in test contest will not be reset when function is loading.

The goal for a better design is to reduce the use of global variable. Now it is only the glb_aiida_config_folder (the original AIIDA_CONFIG_FOLDER). Other three are derived from this one. This lower the possibility of directly access the global variable without noticing its change.

• use a class to derive daemon dir and daemon log dir instead of using 4 global vars.
• Remove usage daemon dir, log dir, access control dir from other modules.

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (ef60b66) to head (6e26eaf).
Report is 193 commits behind head on main.

Files with missing lines	Patch %	Lines
src/aiida/manage/configuration/profile.py	16.67%	5 Missing ⚠️
src/aiida/manage/tests/pytest_fixtures.py	0.00%	3 Missing ⚠️
src/aiida/cmdline/commands/cmd_profile.py	0.00%	2 Missing ⚠️
src/aiida/engine/daemon/client.py	77.78%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6610      +/-   ##
==========================================
+ Coverage   77.51%   77.90%   +0.40%     
==========================================
  Files         560      567       +7     
  Lines       41444    42178     +734     
==========================================
+ Hits        32120    32856     +736     
+ Misses       9324     9322       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[GeigerJ2]

If basedpyright is happy with the code, there is probably nothing I can add :D
Looks good to me! Just a few minor comments.

[unkcpz]

Thanks for the review and great suggestion @danielhollas @sphuber
I addressed all what you mentioned, and ready for another review I think.

[unkcpz]

Hi @danielhollas, please have a look at this when you get time. This is one of the fixes for a random failed test of #6620.

Besides the naming of the get/set methods, it is ready from my side. I prefer to have the method name get/set instead of AiiDAConfigDir.get_configuration_directory().

[danielhollas]

@unkcpz Thanks, I'll have a look today.

One suggestion, it would help if the unrelated typing changes were extracted to a separate PR. But if it would be too much extra work don't worry about it.

Besides the naming of the get/set methods, it is ready from my side. I prefer to have the method name get/set instead of AiiDAConfigDir.get_configuration_directory().

I agree with the rename.

[unkcpz]

One suggestion, it would help if the unrelated typing changes were extracted to a separate PR. But if it would be too much extra work don't worry about it.

Not too many, and I agree it is better to not contaminate the major changes with fix type checking too much. I revert the changes in configuration/profile.py which fixes are not necessary.

I agree with the rename.

Renamed.

[danielhollas]

This looks great! Thanks for sticking with this @unkcpz, very nice cleanup and the settings.py file is now much easier to follow.

[unkcpz]

Thanks for the review and discussion! @sphuber @danielhollas @GeigerJ2