Improve and correct typing of get_object_content and open file repository methods
#6187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/repo-get-object-content-overload
branch
3 times, most recently
from
195ec52 to
0c974b4
Compare
|
I'll start holiday tomorrow till next Tuesday, so unassigned myself from reviewers. |
Added for the `FolderData` and `NodeRepository` classes.
Added for the `FolderData` and `NodeRepository` classes. The signature
of the `SinglefileData` was actually incorrect as it defined:
t.Iterator[t.BinaryIO | t.TextIO]
as the return type, but which should really be:
t.Iterator[t.BinaryIO] | t.Iterator[t.TextIO]
The former will cause `mypy` to raise an error.
sphuber
force-pushed
the
fix/repo-get-object-content-overload
branch
from
0c974b4 to
08684f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.