Skip to content

Remove redundant criteria parameter from GEval instantiation #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove redundant criteria parameter from GEval instantiation #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3e42c2
Initial plan
Copilot Nov 24, 2025
ebb5cd2
Remove duplicate criteria parameter from GEval instantiation
Copilot Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/metacoder/evals/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ def get_default_metrics() -> Dict[str, BaseMetric]:
return {
"CorrectnessMetric": GEval(
name="Correctness",
criteria="Determine whether the actual output is factually correct based on the expected output.",
# NOTE: you can only provide either criteria or evaluation_steps, and not both
evaluation_steps=[
"Check whether the facts in 'actual output' contradicts any facts in 'expected output'",
"You should also heavily penalize omission of detail",
Expand Down
Loading