Fix ensure compatibility with ES and CommonJS module systems for StatoscopeWebpackPlugin #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hoo00nn
commented
Mar 12, 2024
hoo00nn
commented
- Fix compatibility issues arising from differences between CommonJS and ES module systems.
…toscopeWebpackPlugin
hoo00nn
force-pushed
the
fix/default
branch
2 times, most recently
from
3c28330
to
4c50f14
Compare
1 task
ai
reviewed
Mar 12, 2024
| import { join } from 'node:path' | ||
|
|
||
| function addStatoscope(limitConfig, check, webpackConfig) { | ||
| let StatoscopeWebpackPlugin = _StatoscopeWebpackPlugin.default ? _StatoscopeWebpackPlugin.default : _StatoscopeWebpackPlugin; |
There was a problem hiding this comment.
Do you find a reason why it works sometime with default sometimes not?
There was a problem hiding this comment.
I also don't know why it behaves that way. However, in my case, the module operates using the CommonJS format. Due to that error, I have to remove the --why option and configure it manually. What do you think about supporting this?
I've created a test project, and the same issue occurs. How is it in your environment?
|
Thanks. Released in 11.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.