Skip to content

chore(discovery): Use Store interface instead of etcd #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2025
Merged

chore(discovery): Use Store interface instead of etcd #3887

merged 2 commits into from
Oct 27, 2025
+130 −171

Conversation

@grahamking
Copy link
Contributor

Discovery watcher now uses KeyValueStoreManager instead of directly etcd. That allows us to switch to other backends.

Remove unused etcd_client from grpc entrypoint.

Part of larger project to make etcd optional.

@grahamking
chore(discovery): Use Store interface instead of etcd
37a9083 
Discovery watchers now users the `KeyValueStoreManager` instead of
directly etcd. That allows us to switch to other backends.

Remove unused etcd_client from grpc entrypoint.

Signed-off-by: Graham King <[email protected]>
@grahamking grahamking requested a review from a team as a code owner October 24, 2025 21:08
@github-actions github-actions bot added the chore label Oct 24, 2025
@grahamking grahamking requested a review from biswapanda October 24, 2025 22:03
@grahamking
Thanks AI for the review
b1dc1c3 
Signed-off-by: Graham King <[email protected]>
@rmccorm4 rmccorm4 requested a review from kthui October 24, 2025 22:12
kthui
kthui approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@kthui kthui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the refactor made the interface to the key value store (formerly etcd client) much cleaner!

Wondering why we are restraining how quickly the key value watcher must consume an update after it arrives at the key value store.

@grahamking grahamking merged commit 5a0d710 into main Oct 27, 2025
29 of 30 checks passed
@grahamking grahamking deleted the gk-etcd-p4 branch October 27, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kthui kthui kthui approved these changes

@biswapanda biswapanda biswapanda approved these changes

Assignees

No one assigned

Labels

chore size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grahamking @biswapanda @kthui