Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures node requirements are installed independently of AUTO_UPDATE #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensures node requirements are installed independently of AUTO_UPDATE #73

wants to merge 1 commit into from

Conversation

dougbtv
Copy link

@dougbtv dougbtv commented May 9, 2024

Only runs git pull when AUTO_UPDATE is set, otherwise, installs all requirements.

(Still WIP, working on testing the fix)

Fixes #68

@dougbtv
Ensures node requirements are installed independently of AUTO_UPDATE
de82fa1 
Only runs git pull when AUTO_UPDATE is set, otherwise, installs all requirements.
dougbtv
dougbtv commented May 9, 2024
View reviewed changes
config/provisioning/default.sh
fi
fi

printf "Ensuring node requirements: %s...\n" "${repo}"
Copy link
Author

@dougbtv dougbtv May 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my main concern is that this is kind of noisy output in cases when most are already installed? Maybe there's a more elegant way to check if any need update install before output? Feedback welcome of course.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(umm, including the lines below too, that suffers the same ills I'd wager)

@dougbtv dougbtv mentioned this pull request May 9, 2024
Closed
@dougbtv
Copy link
Author

dougbtv commented May 9, 2024 •
edited
Loading

Figured out I can test by setting PROVISIONING_SCRIPT to https://raw.githubusercontent.com/dougbtv/comfyui/provisioning-node-requirements/config/provisioning/default.sh

(and by editing the NODES array at the top of the file with the custom nodes in question in my situation...)

@dougbtv
Copy link
Author

dougbtv commented May 9, 2024

"works on my (cloudified) machine" with PROVSIONING_SCRIPT set to:

https://raw.githubusercontent.com/dougbtv/comfyui/provisioning-node-requirements-tester/config/provisioning/default.sh

Which includes this diff plus a couple items in the NODES array that I had installed with manager.

...It's got me thinking if it needs changes to scan for the installed nodes? unsure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom nodes, imports fails. Moving mamba env to workspace?
1 participant
@dougbtv