Skip to content

Commit

Permalink
add todo
Browse files Browse the repository at this point in the history
  • Loading branch information
ahuang11 committed Jun 15, 2024
1 parent 7ef0a6c commit ad63875
Showing 1 changed file with 3 additions and 16 deletions.
19 changes: 3 additions & 16 deletions streamjoy/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -372,26 +372,13 @@ def _select_element(key, hv_obj=None):
if len(kdims) > 1:
raise ValueError("Can only handle 1D HoloViews objects.")

# if isinstance(hv_map, hv.core.spaces.DynamicMap):
# logging.warning(
# "HoloViews DynamicMap objects may be slow to serialize "
# "due to the need to render each frame individually..."
# )
# TODO: experiment with this as keys instead and push holoviews object as iterables
# for i in range(nframes):
# plot.update(i)
resources = [
_select_element(key, hv_obj=hv_obj)
for key in keys[: kwargs.get("max_frames")]
]
# else:
# client = _utils.get_distributed_client()
# resources = _utils.map_over(
# client,
# _select_element,
# keys[: kwargs.get("max_frames")],
# kwargs.get("batch_size"),
# hv_obj=hv_obj,
# wait=True
# )

renderer_kwargs = renderer_kwargs or {}
renderer_kwargs.update(_utils.pop_from_cls(stream_cls, kwargs))

Expand Down

0 comments on commit ad63875

Please sign in to comment.