Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash and build #1281

Merged
merged 6 commits into from
Jan 5, 2025
Merged

fix: crash and build #1281

merged 6 commits into from
Jan 5, 2025

Conversation

KorigamiK
Copy link

This fixes linux builds with qt 6.8.
Fixes crash when calling SetWindowRectCommand with bad input

@ahrm
Copy link
Owner

ahrm commented Jan 5, 2025

  1. Can you squash these commits, there are some commits that are undoing each other's work, they needlessly pollute the history.
  2. No need to do an ifdef for the header, just use #include <QThread> if the other one doesn't work.

@KorigamiK
Copy link
Author

You can squash the commits when merging on GitHub (click the drop-down next to the merge button)

I couldn't figure out why the ci is failing so I added that ifdef, is it not because of that?

@ahrm ahrm merged commit f85bb89 into ahrm:development Jan 5, 2025
8 of 10 checks passed
@ahrm
Copy link
Owner

ahrm commented Jan 5, 2025

No, the reason for the build failure was a mistake on my part, I should have included either qthread.h or QThread but instead I included qthread, it did not trigger an error for me on windows because paths are case-insensitive on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants