-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write additional metadata back into the source sheet #4
base: master
Are you sure you want to change the base?
Conversation
While technically path components are case sensitive, I have no personal need for case-sensitive redirection.
Upon redirect, record the current time into the correct row.
Give users the ability to specify the HTTP response code to use. Default is 301 - Moved Permanantly.
Make sheet writes in one goroutine. Also, make sure that the writes are thread-safe using mutexes.
I don't think I'll accept the write requests back into the sheet. They will be buggy on concurrent instances. Resp codes do not sound very useful either. |
Fair enough. Do you want the case-insensitive bit? I can cherry pick it out
if you do, otherwise no worries - and thank you for making this!
…On Sun, Jan 22, 2023 at 9:15 AM Ahmet Alp Balkan ***@***.***> wrote:
I don't think I'll accept the write requests back into the sheet. They
will be buggy on concurrent instances. Resp codes do not sound very useful
either.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTCAGN4Y5NTIDKJTRFQYZLWTVTMHANCNFSM6AAAAAAUDCO7PE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Even then, I don't wanna break anyone's workflow without them noticing. I personally don't use uppercase at all and it does not seem like I'd need it. |
I don't think it would be a breaking change for lookups that currently work - the lookup key is already lowercased here: https://github.com/ahmetb/sheets-url-shortener/blob/master/main.go#L189-L200 I believe this means is that if I have a shortcut It may possibly impact users if they depend on mixed-case shortcuts not ever redirecting - e.g. if you have a shortcut for |
There's three changes in this PR - let me know if you would prefer I break it up into three separate PRs.