Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display data for specific countries in one command #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djuric
Copy link

@djuric djuric commented Mar 22, 2020

First of all thank you for this project, it's very useful and easy to use :)

I think this addition would be really nice, it's a way to display data for specific countries separated by '-'. For example:

corona italy-spain

or

corona us-uk-italy-spain

This way we can compare data from selected countries in the same table.

@ahmadawais
Copy link
Owner

Glad you like my work. This is a fantastic idea. Something I have been thinking about.

Some countries have - in their names. So maybe we should use a different separator. Let's say _? Thoughts?

@ahmadawais
Copy link
Owner

This fixes #15.

@djuric
Copy link
Author

djuric commented Mar 22, 2020

@ahmadawais you are right, it looks like there can be a country with - in the name. And & (which would be nice) will not work either because it's recognized as next command.

So yes, _ is a good candidate. I was also thinking about / but this looks a bit odd, it implies it's a directory path :)

utils/getCountries.js Outdated Show resolved Hide resolved
@ahmadawais
Copy link
Owner

Thanks for the PR. Can you please update the PR in light of the latest release.

🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.4.0
🔗 https://www.npmjs.com/package/corona-cli

@fayazmiraz
Copy link

@ahmadawais you are right, it looks like there can be a country with - in the name. And & (which would be nice) will not work either because it's recognized as next command.

So yes, _ is a good candidate. I was also thinking about / but this looks a bit odd, it implies it's a directory path :)

What about comma? Like: usa,italy,spain

@ahmadawais
Copy link
Owner

Aha , would be perfect!

@ahmadawais
Copy link
Owner

Can you update this PR with , as the separator and use the new route where you can just define a list of countries?

https://corona.lmao.ninja/countries/us,italy,spain

@djuric djuric reopened this Apr 13, 2020
@djuric
Copy link
Author

djuric commented Apr 14, 2020

@ahmadawais , added as a separator. It looks and works better then other symbols, thanks @fayazmiraz :)

@fayazmiraz
Copy link

@ahmadawais , added as a separator. It looks and works better then other symbols, thanks @fayazmiraz :)

Great, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants