Skip to content

Make dashboard progress reflect both driving requirements - #30

Merged
ahernsean merged 1 commit into
mainfrom
dashboard-overall-requirements-progress
Sep 8, 2026
Merged

ahernsean merged 1 commit into
mainfrom
dashboard-overall-requirements-progress

Conversation

@ahernsean

Copy link
Copy Markdown
Owner

Summary

  • calculate center progress from the greater of total and nighttime driving still required
  • keep the total and nighttime arcs as separate measures
  • show until both requirements are met

Validation

  • PYTHONPATH=. .venv/bin/ruff check .
  • PYTHONPATH=. .venv/bin/ruff format --check .
  • PYTHONPATH=. .venv/bin/mypy
  • PYTHONPATH=. .venv/bin/pytest -m "not browser" --cov --cov-report=term-missing --cov-fail-under=95
  • DRIVING_LOG_WEBKIT_WS_ENDPOINT=ws://127.0.0.1:31747/ PYTHONPATH=. .venv/bin/pytest -m browser

@ahernsean

Copy link
Copy Markdown
Owner Author

@codex Review this PR

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 98c13ff4e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ahernsean
ahernsean merged commit 32f29ef into main Sep 8, 2026
5 checks passed
@ahernsean
ahernsean deleted the dashboard-overall-requirements-progress branch September 8, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant