Skip to content

Streamline manual drive entry and make overlap warnings DST-safe - #19

Merged
ahernsean merged 3 commits into
mainfrom
claude/manual-drive-entry-improvements-gqe3i0
Aug 9, 2026
Merged

ahernsean merged 3 commits into
mainfrom
claude/manual-drive-entry-improvements-gqe3i0

Conversation

@ahernsean

@ahernsean ahernsean commented Aug 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Manual entry and editing always record Daniel as the driver, so the form no longer prompts for it. The dashboard action is now labeled “Add drive,” and a new-entry form has a Cancel link.
  • Drive details now offers “Add another drive,” which pre-fills the prior drive’s supervisor, road type, weather, and end location and starts at its end instant.
  • The time editor warns live when an entry overlaps a saved drive. Saved intervals remain UTC instants, and the form preserves/resolves DST folds in America/New_York so repeated fall-back-hour entries and overlap checks are correct.

Test plan

  • PYTHONPATH=. .venv/bin/ruff check .
  • PYTHONPATH=. .venv/bin/ruff format --check .
  • PYTHONPATH=. .venv/bin/mypy
  • PYTHONPATH=. .venv/bin/pytest -m "not browser" --cov --cov-report=term-missing --cov-fail-under=95 (95.38% coverage)
  • PYTHONPATH=. DRIVING_LOG_BROWSER=chromium-local .venv/bin/pytest -m browser (3 passed; local WebKit dependencies unavailable)
  • git diff --check

GitHub CI is green, including the WebKit browser job.

…nd overlap warning

- The driver is always Daniel, so the manual entry/edit form no longer
  prompts for it; it's submitted as a hidden field instead.
- Drive details now has an "Add another manual drive" button that opens
  a new entry form pre-filled with the prior drive's supervisor, road
  type, weather, and end location, with the start time picking up where
  the prior drive ended.
- The time editor now warns live, client-side, when the entered start/end
  would overlap another saved drive, mirroring the existing short-drive
  warning. Existing drive intervals are sent to the browser as local
  wall-clock strings (not UTC) so the comparison is correct regardless of
  the device's own clock timezone.
@ahernsean
ahernsean force-pushed the claude/manual-drive-entry-improvements-gqe3i0 branch from e28d152 to 91861f9 Compare August 7, 2026 16:18
Comment thread driving_log/static/app.js
Comment thread driving_log/web.py Outdated
Comment thread driving_log/static/app.js
@ahernsean ahernsean changed the title Streamline manual drive entry: skip driver prompt, repeat entry, overlap warning Streamline Add drive entry and DST-safe overlap warnings Aug 9, 2026
@ahernsean ahernsean changed the title Streamline Add drive entry and DST-safe overlap warnings Streamline manual drive entry and make overlap warnings DST-safe Aug 9, 2026
@ahernsean
ahernsean merged commit 2f92794 into main Aug 9, 2026
5 checks passed
@ahernsean
ahernsean deleted the claude/manual-drive-entry-improvements-gqe3i0 branch August 9, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants