Skip to content

docs: add DCO sign-off instructions to contributing guide#4477

Open
markmandel wants to merge 1 commit intoagones-dev:mainfrom
markmandel:buid/dco-requirements
Open

docs: add DCO sign-off instructions to contributing guide#4477
markmandel wants to merge 1 commit intoagones-dev:mainfrom
markmandel:buid/dco-requirements

Conversation

@markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Adds a Developer Certificate of Origin (DCO) subsection under the "Submitting code via Pull Requests" section, covering how to sign commits and how to retroactively sign off on existing commits.

Which issue(s) this PR fixes:

Work on #4421

Special notes for your reviewer:

Wrote this while about to get on a plane, so hopefully not too much of a rush 😁

Adds a Developer Certificate of Origin (DCO) subsection under the
"Submitting code via Pull Requests" section, covering how to sign
commits and how to retroactively sign off on existing commits.

Signed-off-by: Mark Mandel <mark@compoundtheory.com>
@markmandel markmandel added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Mar 21, 2026
@github-actions github-actions bot added kind/documentation Documentation for Agones size/S labels Mar 21, 2026
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason do choosing this option over the EasyCLA?

@markmandel
Copy link
Collaborator Author

It's not either or - DCO is required. If you also want to add a CLA you can (but it doesn't seem necessary, the less lawyers the better ☺️)

Ensure that DCO are enabled for all GitHub repositories of the project. You may also choose to use a CLA.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 57a52885-849a-4594-89a8-c5a6bf79782e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4477/head:pr_4477 && git checkout pr_4477
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.57.0-dev-7da53a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/documentation Documentation for Agones size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants